我們先來寫User類的單元測試,定義3個測試方法:
- require File.dirname(__FILE__) + '/../test_helper'
- class UserTest < Test::Unit::TestCase
- fixtures :users
- def test_full_name_without_middle_initial
- user = User.new(:first_name => 'John', :last_name => 'Doe')
- assert_equal 'John Doe', user.full_name
- end
- def test_full_name_with_middle_initial
- user = User.new(:first_name => 'John', :middle_initial => 'H', :last_name => 'Doe')
- assert_equal 'John H. Doe', user.full_name
- end
- def test_full_name_with_blank_middle_initial
- user = User.new(:first_name => 'John', :middle_initial => '', :last_name => 'Doe')
- assert_equal 'John Doe', user.full_name
- end
- end
我們再看看我們的full_name方法,顯然是無法滿足所有的測試的:
- class User < ActiveRecord::Base
- def full_name
- name = first_name
- name += "#{middle_initial}." unless middle_initial.nil?
- name += last_name
- name
- end
- end
而且middle_initial後面跟一個"."也讓我們的代碼"風水"不好,比如我們突然有一天把"."改成"-"呢?好,我們繼續重構吧:
- class User < ActiveRecord::Base
- def full_name
- [first_name, middle_initial_with_period, last_name].compact.join(' ')
- end
- def middle_initial_with_period
- "#{middle_initial}." unless middle_initial.blank?
- end
- end
運行測試,ok,通過了!